Re: [Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails

2013-08-21 Thread Doug Goldstein
On Wed, Aug 21, 2013 at 9:08 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > Print a warning when opening a file O_DIRECT on tmpfs fails. This saves > > Only when it fails with EINVAL, actually. Suggest "on tmpfs fails with > EINVAL." > > > users a lot of time trying to figure out

Re: [Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails

2013-08-21 Thread Eric Blake
On 08/21/2013 07:16 AM, Stefan Hajnoczi wrote: > Print a warning when opening a file O_DIRECT on tmpfs fails. This saves > users a lot of time trying to figure out the EINVAL error. > > Daniel P. Berrange suggested opening the file > without O_DIRECT as a portable way to check whether the file s

Re: [Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails

2013-08-21 Thread Eric Blake
On 08/21/2013 07:16 AM, Stefan Hajnoczi wrote: > Print a warning when opening a file O_DIRECT on tmpfs fails. This saves > users a lot of time trying to figure out the EINVAL error. > > Daniel P. Berrange suggested opening the file > without O_DIRECT as a portable way to check whether the file s

Re: [Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails

2013-08-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > Print a warning when opening a file O_DIRECT on tmpfs fails. This saves Only when it fails with EINVAL, actually. Suggest "on tmpfs fails with EINVAL." > users a lot of time trying to figure out the EINVAL error. > > Daniel P. Berrange suggested opening the file > w

[Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails

2013-08-21 Thread Stefan Hajnoczi
Print a warning when opening a file O_DIRECT on tmpfs fails. This saves users a lot of time trying to figure out the EINVAL error. Daniel P. Berrange suggested opening the file without O_DIRECT as a portable way to check whether the file system supports O_DIRECT. That gets messy when flags cont