Re: [Qemu-devel] [PATCH v2 2/2] slirp: Handle error returns from sosendoob()

2017-07-15 Thread Samuel Thibault
Dr. David Alan Gilbert, on ven. 14 juil. 2017 15:24:19 +0100, wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > sosendoob() can return a failure code, but all its callers ignore it. > > This is OK in sbappend(), as the comment there states -- we will try > > again later in sowrite(). A

Re: [Qemu-devel] [PATCH v2 2/2] slirp: Handle error returns from sosendoob()

2017-07-14 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > sosendoob() can return a failure code, but all its callers ignore it. > This is OK in sbappend(), as the comment there states -- we will try > again later in sowrite(). Add a (void) cast to tell Coverity so. > In sowrite() we do need to check the

[Qemu-devel] [PATCH v2 2/2] slirp: Handle error returns from sosendoob()

2017-07-14 Thread Peter Maydell
sosendoob() can return a failure code, but all its callers ignore it. This is OK in sbappend(), as the comment there states -- we will try again later in sowrite(). Add a (void) cast to tell Coverity so. In sowrite() we do need to check the return value -- we should handle a write failure in sosend