Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 09:16, Fam Zheng ha scritto: > On Mon, 09/15 12:17, Paolo Bonzini wrote: >> Il 15/09/2014 07:23, Fam Zheng ha scritto: >>> SCSIRequest *sreq; >>> size_t resp_size; >>> enum SCSIXferMode mode; >>> -QEMUIOVector resp_iov; >>> union { >>> VirtIOSCSICmdRes

Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-16 Thread Fam Zheng
On Mon, 09/15 12:17, Paolo Bonzini wrote: > Il 15/09/2014 07:23, Fam Zheng ha scritto: > > SCSIRequest *sreq; > > size_t resp_size; > > enum SCSIXferMode mode; > > -QEMUIOVector resp_iov; > > union { > > VirtIOSCSICmdResp cmd; > > VirtIOSCSICtrlTMFResp

Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 07:23, Fam Zheng ha scritto: > SCSIRequest *sreq; > size_t resp_size; > enum SCSIXferMode mode; > -QEMUIOVector resp_iov; > union { > VirtIOSCSICmdResp cmd; > VirtIOSCSICtrlTMFResp tmf; > @@ -68,23 +75,27 @@ static inline SCSIDevice > *vi

[Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-14 Thread Fam Zheng
The VirtQueueElement is a very big structure (>48k!), since it will be initialzed by virtqueue_pop, we can save the expensive zeroing here. This saves a few microseconds per request in my test: [fio-test] rw bs iodepthjobs bw iops latency