Re: [Qemu-devel] [PATCH v2 2/3] block/stream: refactor stream_run: drop goto

2019-04-03 Thread Andrey Shinkevich
On 02/04/2019 15:43, Alberto Garcia wrote: > On Mon 01 Apr 2019 02:06:04 PM CEST, Andrey Shinkevich wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: Andrey Shinkevich >> --- > > You can also say in the log message that the goto i

Re: [Qemu-devel] [PATCH v2 2/3] block/stream: refactor stream_run: drop goto

2019-04-02 Thread Alberto Garcia
On Mon 01 Apr 2019 02:06:04 PM CEST, Andrey Shinkevich wrote: > From: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Andrey Shinkevich > --- You can also say in the log message that the goto is not necessary since the common exit code was removed i

[Qemu-devel] [PATCH v2 2/3] block/stream: refactor stream_run: drop goto

2019-04-01 Thread Andrey Shinkevich
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/stream.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/block/stream.c b/block/stream.c index 6253c86..c065e99 100644 --- a/block/stream.