Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-14 Thread Stefan Hajnoczi
On Fri, May 10, 2013 at 10:02:14PM -0600, Eric Blake wrote: > On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote: > > @block-backup > > > > +++ b/qapi-schema.json > > @@ -1715,6 +1715,37 @@ > > '*speed': 'int' } } > > > > ## > > +# @block-backup > > +# > > +# Start a point-in-time copy

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-14 Thread Stefan Hajnoczi
On Wed, May 08, 2013 at 02:49:00PM +0200, Kevin Wolf wrote: > Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: > > @block-backup > > > > Start a point-in-time copy of a block device to a new destination. The > > status of ongoing block backup operations can be checked with > > query-block-

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Wenchao Xia
于 2013-5-13 22:50, Eric Blake 写道: On 05/13/2013 08:27 AM, Kevin Wolf wrote: I think long term we'll need a dynamic schema anyway. As we go forward with modularisation and putting things into shared libraries, we'll have modules that add support for commands, enum values, etc. In other words, q

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Eric Blake
On 05/13/2013 08:27 AM, Kevin Wolf wrote: > I think long term we'll need a dynamic schema anyway. As we go forward > with modularisation and putting things into shared libraries, we'll have > modules that add support for commands, enum values, etc. In other words, qapi-schema.json should have a wa

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Kevin Wolf
Am 13.05.2013 um 16:14 hat Eric Blake geschrieben: > On 05/13/2013 07:18 AM, Luiz Capitulino wrote: > Luiz, any idea how to do something like this, a QAPI enum with values > that are determined at runtime? Especially with respect to the coming > schema introspection? > >>> > >>> Or m

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Eric Blake
On 05/13/2013 07:18 AM, Luiz Capitulino wrote: Luiz, any idea how to do something like this, a QAPI enum with values that are determined at runtime? Especially with respect to the coming schema introspection? >>> >>> Or maybe we make the 'enum' list ALL possible types, but then add a

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 15:09:31 +0200 Kevin Wolf wrote: > Am 13.05.2013 um 14:56 hat Eric Blake geschrieben: > > On 05/13/2013 02:28 AM, Kevin Wolf wrote: > > > > >>> +{ 'command': 'block-backup', > > >>> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > > >> > > >> Hmm - wondering

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Kevin Wolf
Am 13.05.2013 um 14:56 hat Eric Blake geschrieben: > On 05/13/2013 02:28 AM, Kevin Wolf wrote: > > >>> +{ 'command': 'block-backup', > >>> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > >> > >> Hmm - wondering if we should add an enum type for supported disk formats > >> instea

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Eric Blake
On 05/13/2013 02:28 AM, Kevin Wolf wrote: >>> +{ 'command': 'block-backup', >>> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', >> >> Hmm - wondering if we should add an enum type for supported disk formats >> instead of using free-form strings. The wire representation would be >

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Kevin Wolf
Am 11.05.2013 um 06:02 hat Eric Blake geschrieben: > On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote: > > @block-backup > > > > +++ b/qapi-schema.json > > @@ -1715,6 +1715,37 @@ > > '*speed': 'int' } } > > > > ## > > +# @block-backup > > +# > > +# Start a point-in-time copy of a bloc

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Kevin Wolf
Am 11.05.2013 um 05:34 hat Eric Blake geschrieben: > On 05/08/2013 06:49 AM, Kevin Wolf wrote: > > Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: > >> @block-backup > >> > > > drive-backup would probably be a more consistent naming. We would then > > still have block-backup for a future l

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-11 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 11/05/2013 05:34, Eric Blake ha scritto: > On 05/08/2013 06:49 AM, Kevin Wolf wrote: >> Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: >>> @block-backup >>> > >> drive-backup would probably be a more consistent naming. We would >> then st

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-10 Thread Eric Blake
On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote: > @block-backup > > +++ b/qapi-schema.json > @@ -1715,6 +1715,37 @@ > '*speed': 'int' } } > > ## > +# @block-backup > +# > +# Start a point-in-time copy of a block device to a new destination. The > +# status of ongoing block backup o

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-10 Thread Eric Blake
On 05/08/2013 06:49 AM, Kevin Wolf wrote: > Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: >> @block-backup >> > drive-backup would probably be a more consistent naming. We would then > still have block-backup for a future low-level command that doesn't > create everything by itself but t

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-08 Thread Kevin Wolf
Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: > @block-backup > > Start a point-in-time copy of a block device to a new destination. The > status of ongoing block backup operations can be checked with > query-block-jobs. The operation can be stopped before it has completed using > the

[Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-01 Thread Stefan Hajnoczi
@block-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing block backup operations can be checked with query-block-jobs. The operation can be stopped before it has completed using the block-job-cancel command. @device: the name of the device whose wri