Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable

2013-04-15 Thread Jesse Larrew
On 04/14/2013 09:14 PM, liguang wrote: #ifdef DEBUG_DEBUGCON -printf(debugcon: write addr=0x%04 HWADDR_PRIx val=0x%02x\n, addr, val); +printf( [debugcon: write addr=0x%04 HWADDR_PRIx val=0x%02]\n, addr, val); I like the reformatting, but it looks like you accidentally clobbered

Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable

2013-04-15 Thread li guang
在 2013-04-15一的 21:44 -0500，Jesse Larrew写道： On 04/14/2013 09:14 PM, liguang wrote: #ifdef DEBUG_DEBUGCON -printf(debugcon: write addr=0x%04 HWADDR_PRIx val=0x%02x\n, addr, val); +printf( [debugcon: write addr=0x%04 HWADDR_PRIx val=0x%02]\n, addr, val); I like the

[Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable

2013-04-14 Thread liguang
before change: Bdebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x74 tdebugcon: write addr=0x val=0x69 idebugcon: write addr=0x val=0x6e ndebugcon: write addr=0x val=0x67 gdebugcon: write addr=0x val=0x20 debugcon: write