Re: [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2019-01-02 Thread Stefan Hajnoczi
On Sun, Dec 23, 2018 at 10:59:38AM +0800, yuchenlin wrote: > Signed-off-by: yuchenlin > --- > block/dmg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:03, yuchenlin escreveu: > Signed-off-by: yuchenlin > --- > block/dmg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/dmg.c b/block/dmg.c > index 0e05702f5d..6b0a057bf8 100644 >

[Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2018-12-22 Thread yuchenlin
Signed-off-by: yuchenlin --- block/dmg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/dmg.c b/block/dmg.c index 0e05702f5d..6b0a057bf8 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -267,7 +267,7 @@ static int dmg_read_mish_block(BDRVDMGState *s, DmgHeaderState