Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 05:01:54PM +0100, Igor Mammedov wrote: On Thu, 12 Feb 2015 13:24:26 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote: [...] +DECLARE_BITMAP(present_cpus, MAX_CPUMASK_BITS); naming is a bit

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- numa.c | 27

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 15:22, Igor Mammedov wrote: how about replacing a bunch if fprintf's with something like this: cpu = 0; while((cpu = find_next_bit(present_cpus, MAX_CPUMASK_BITS, cpu + 1)) !=MAX_CPUMASK_BITS) str = g_strdup_printf(%s %d, str, cpu); error_report(CPU(s) present in

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote: On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- numa.c | 27

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 04:18:31PM +0100, Paolo Bonzini wrote: On 12/02/2015 15:22, Igor Mammedov wrote: how about replacing a bunch if fprintf's with something like this: cpu = 0; while((cpu = find_next_bit(present_cpus, MAX_CPUMASK_BITS, cpu + 1)) !=MAX_CPUMASK_BITS) str =

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Thu, 12 Feb 2015 13:24:26 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote: On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Each CPU can appear in only one NUMA node on the NUMA config.

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Thu, 12 Feb 2015 16:18:31 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 12/02/2015 15:22, Igor Mammedov wrote: how about replacing a bunch if fprintf's with something like this: cpu = 0; while((cpu = find_next_bit(present_cpus, MAX_CPUMASK_BITS, cpu + 1))

[Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-09 Thread Eduardo Habkost
Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- numa.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/numa.c b/numa.c index