Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-31 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Tuesday, August 26, 2014 10:25 AM > Subject: Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in > device_set_realized() to avoid resource leak > >

Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-25 Thread Gonglei (Arei)
rei) > Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Michael S. Tsirkin; > Luonengjun; Huangpeng (Peter); Igor Mammedov; Paolo Bonzini; Andreas > Färber > Subject: Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in > device_set_realized() to avoid resource leak >

Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-25 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 12:11 PM, wrote: > From: Gonglei > > At present, this function doesn't have partial cleanup implemented, > which will cause resource leak in some scenarios. > > Example: > > 1. Assuming that "dc->realize(dev, &local_err)" execute successful >and local_err == NULL; > 2

Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-25 Thread Gonglei (Arei)
Ping, please. Any comments? Thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, August 21, 2014 10:11 AM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); pbonz...@redhat.com; > afaer...@suse.de; imamm...@redhat.com; peter.cros

[Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-20 Thread arei.gonglei
From: Gonglei At present, this function doesn't have partial cleanup implemented, which will cause resource leak in some scenarios. Example: 1. Assuming that "dc->realize(dev, &local_err)" execute successful and local_err == NULL; 2. Executing device hotplug in hotplug_handler_plug(), but fa