Re: [Qemu-devel] [PATCH v2 2/3] scripts: Remove debug parameter from QEMUMonitorProtocol

2017-10-10 Thread Lukáš Doktor
Dne 10.10.2017 v 04:49 Eduardo Habkost napsal(a): > On Sat, Oct 07, 2017 at 10:26:14AM +0200, Lukáš Doktor wrote: >> Dne 5.10.2017 v 19:20 Eduardo Habkost napsal(a): >>> Use logging module for the QMP debug messages. The only scripts >>> that set debug=True are iotests.py and guestperf/engine.py,

Re: [Qemu-devel] [PATCH v2 2/3] scripts: Remove debug parameter from QEMUMonitorProtocol

2017-10-09 Thread Eduardo Habkost
On Sat, Oct 07, 2017 at 10:26:14AM +0200, Lukáš Doktor wrote: > Dne 5.10.2017 v 19:20 Eduardo Habkost napsal(a): > > Use logging module for the QMP debug messages. The only scripts > > that set debug=True are iotests.py and guestperf/engine.py, and > > they already call logging.basicConfig() to se

Re: [Qemu-devel] [PATCH v2 2/3] scripts: Remove debug parameter from QEMUMonitorProtocol

2017-10-07 Thread Lukáš Doktor
Dne 5.10.2017 v 19:20 Eduardo Habkost napsal(a): > Use logging module for the QMP debug messages. The only scripts > that set debug=True are iotests.py and guestperf/engine.py, and > they already call logging.basicConfig() to set up logging. > > Scripts that don't configure logging are safe as lo

[Qemu-devel] [PATCH v2 2/3] scripts: Remove debug parameter from QEMUMonitorProtocol

2017-10-05 Thread Eduardo Habkost
Use logging module for the QMP debug messages. The only scripts that set debug=True are iotests.py and guestperf/engine.py, and they already call logging.basicConfig() to set up logging. Scripts that don't configure logging are safe as long as they don't need debugging output, because debug messa