[Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image

2012-10-16 Thread Jeff Cody
This simplifies some code and error checking, and also fixes a bug. bdrv_find_backing_image() should only be passed absolute filenames, or filenames relative to the chain. In the QMP message handler for block commit, when looking up the base do so from the determined top image, so we know it is r

Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image

2012-10-16 Thread Eric Blake
On 10/16/2012 08:44 AM, Jeff Cody wrote: > This simplifies some code and error checking, and also fixes a bug. > > bdrv_find_backing_image() should only be passed absolute filenames, > or filenames relative to the chain. In the QMP message handler for > block commit, when looking up the base do s

Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image

2012-10-16 Thread Jeff Cody
On 10/16/2012 11:22 AM, Eric Blake wrote: > On 10/16/2012 08:44 AM, Jeff Cody wrote: >> This simplifies some code and error checking, and also fixes a bug. >> >> bdrv_find_backing_image() should only be passed absolute filenames, >> or filenames relative to the chain. In the QMP message handler fo

Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image

2012-10-16 Thread Eric Blake
On 10/16/2012 09:31 AM, Jeff Cody wrote: >> Also, I raised another bug[1] about a bad error message regarding >> top_bs, if the user passes a different spelling than the canonical name >> of the active image. Is that worth fixing in this series, or is it okay >> to leave it until you actually add