Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-22 Thread David Gibson
On Mon, May 22, 2017 at 09:41:48AM +0200, Markus Armbruster wrote: > Greg Kurz writes: > > > On Sat, 20 May 2017 16:45:09 +1000 > > David Gibson wrote: > > > >> On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: > >> > If the user explicitely

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-22 Thread Markus Armbruster
Greg Kurz writes: > On Sat, 20 May 2017 16:45:09 +1000 > David Gibson wrote: > >> On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: >> > If the user explicitely asked for kernel-irqchip support and "xics-kvm" >> > initialization fails, we

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-21 Thread David Gibson
On Sun, May 21, 2017 at 07:03:33PM +0200, Greg Kurz wrote: > On Sat, 20 May 2017 16:45:09 +1000 > David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: > > > If the user explicitely asked for kernel-irqchip support and "xics-kvm" > > >

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-21 Thread Greg Kurz
On Sat, 20 May 2017 16:45:09 +1000 David Gibson wrote: > On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: > > If the user explicitely asked for kernel-irqchip support and "xics-kvm" > > initialization fails, we shouldn't fallback to emulated "xics" as we >

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-21 Thread David Gibson
On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: > If the user explicitely asked for kernel-irqchip support and "xics-kvm" > initialization fails, we shouldn't fallback to emulated "xics" as we > do now. It is also awkward to print an error message when we have an > errp pointer

[Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-19 Thread Greg Kurz
If the user explicitely asked for kernel-irqchip support and "xics-kvm" initialization fails, we shouldn't fallback to emulated "xics" as we do now. It is also awkward to print an error message when we have an errp pointer argument. Let's use the errp argument to report the error and let the