Will be used to pass hole ranges to guests.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/i386/pc.c | 39 ++-
hw/i386/pc_piix.c | 14 +-
hw/i386/pc_q35.c | 6 +-
hw/pci-host/q35.c | 4
Hi,
+} else {
+guest_info-pci_info.w64.begin = 0x1ULL + above_4g_mem_size;
+guest_info-pci_info.w64.end = guest_info-pci_info.w64.begin +
+(0x1ULL 62);
Doesn't this give unaligned windows?
+/* Set PCI window size the way seabios has always
On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote:
Hi,
+} else {
+guest_info-pci_info.w64.begin = 0x1ULL +
above_4g_mem_size;
+guest_info-pci_info.w64.end = guest_info-pci_info.w64.begin +
+(0x1ULL 62);
Doesn't this give
I can't offer any opinion about the values you put into w32 and w64, but I have
some remarks.
First, please consider passing -O/path/to/some/order_file to git-format-patch,
so that .h files show up at the top of each patch.
On 05/30/13 13:07, Michael S. Tsirkin wrote:
Will be used to pass
On 05/30/13 14:19, Michael S. Tsirkin wrote:
On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote:
Hi,
+} else {
+guest_info-pci_info.w64.begin = 0x1ULL +
above_4g_mem_size;
+guest_info-pci_info.w64.end = guest_info-pci_info.w64.begin +
+
On Thu, May 30, 2013 at 02:25:41PM +0200, Laszlo Ersek wrote:
I can't offer any opinion about the values you put into w32 and w64, but I
have some remarks.
First, please consider passing -O/path/to/some/order_file to
git-format-patch, so that .h files show up at the top of each patch.
On Thu, May 30, 2013 at 02:32:01PM +0200, Gerd Hoffmann wrote:
On 05/30/13 14:19, Michael S. Tsirkin wrote:
On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote:
Hi,
+} else {
+guest_info-pci_info.w64.begin = 0x1ULL +
above_4g_mem_size;
+
On Thu, May 30, 2013 at 02:07:19PM +0300, Michael S. Tsirkin wrote:
Will be used to pass hole ranges to guests.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/i386/pc.c | 39 ++-
hw/i386/pc_piix.c | 14 +-
Hi,
I see. I'll figure out the details and add a comment to this end.
But that's for the 32 bit window - I don't see it playing
with mtrrs for the 64 bit ranges.
So I'm guessing alignment isn't needed there, right?
mtrr's are a 32bit thing anyway IIRC.
I still would place the 64bit
