Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 17:44, Eric Blake wrote: > On 1/10/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: >> 10.01.2019 10:13, Eric Blake wrote: >>> The existing NBD code had a weird split where nbd_export_new() >>> created an export but did not add it to the list of exported >>> names until a later nbd_export

Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-10 Thread Eric Blake
On 1/10/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.01.2019 10:13, Eric Blake wrote: >> The existing NBD code had a weird split where nbd_export_new() >> created an export but did not add it to the list of exported >> names until a later nbd_export_set_name() came along and grabbed >> a se

Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > The existing NBD code had a weird split where nbd_export_new() > created an export but did not add it to the list of exported > names until a later nbd_export_set_name() came along and grabbed > a second reference on the object; later, nbd_export_close() > drop

[Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-09 Thread Eric Blake
The existing NBD code had a weird split where nbd_export_new() created an export but did not add it to the list of exported names until a later nbd_export_set_name() came along and grabbed a second reference on the object; later, nbd_export_close() drops the second reference. But since we never ch