Re: [Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-05 Thread Cornelia Huck
On Wed, 5 Sep 2012 09:22:32 +0200 Heiko Carstens wrote: > On Tue, Sep 04, 2012 at 05:13:25PM +0200, Cornelia Huck wrote: > > Just some quick comments: > > [...] > > > int kvm_s390_inject_program_int(struct kvm_vcpu *vcpu, u16 code) > > { > > struct kvm_s390_local_interrupt *li = &vcpu->a

Re: [Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-05 Thread Heiko Carstens
On Tue, Sep 04, 2012 at 05:13:25PM +0200, Cornelia Huck wrote: Just some quick comments: [...] > int kvm_s390_inject_program_int(struct kvm_vcpu *vcpu, u16 code) > { > struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int; > @@ -648,6 +747,12 @@ int kvm_s390_inject_vm(struct kvm *k

[Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-04 Thread Cornelia Huck
Add support for injecting machine checks (only repressible conditions for now). This is a bit more involved than I/O interrupts, for these reasons: - Machine checks come in both floating and cpu varieties. - We don't have a bit for machine checks enabling, but have to use a roundabout approach