Re: [Qemu-devel] [PATCH v2 2/8] hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus

2017-01-27 Thread Alistair Francis
On Thu, Jan 26, 2017 at 7:09 AM, Markus Armbruster wrote: > Machine types cubieboard, xlnx-ep108, xlnx-zcu102 have an onboard AHCI > controller, but neglect to set their MachineClass member > units_per_default_bus = 1. This permits -drive if=ide,unit=1, which > makes no sense for AHCI. It also s

[Qemu-devel] [PATCH v2 2/8] hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus

2017-01-26 Thread Markus Armbruster
Machine types cubieboard, xlnx-ep108, xlnx-zcu102 have an onboard AHCI controller, but neglect to set their MachineClass member units_per_default_bus = 1. This permits -drive if=ide,unit=1, which makes no sense for AHCI. It also screws up index=N for odd N, because it gets desugared to unit=1,bus