Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Andreas Färber
Am 04.01.2011 um 17:11 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 03:51:37PM +, Peter Maydell wrote: On 4 January 2011 15:15, Aurelien Jarno wrote: Use bits32 instead of uint32 when manipulating floating point values directly for consistency reasons. I'm not convinced this patch is

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Peter Maydell
On 4 January 2011 16:11, Aurelien Jarno wrote: > On Tue, Jan 04, 2011 at 03:51:37PM +, Peter Maydell wrote: >> >  int float32_is_quiet_nan( float32 a1 ) >> >  { >> >     float32u u; >> > -    uint64_t a; >> > +    bits32 a; >> >     u.f = a1; >> >     a = u.i; >> >     return ( 0xFF80 < (

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Aurelien Jarno
On Tue, Jan 04, 2011 at 03:51:37PM +, Peter Maydell wrote: > On 4 January 2011 15:15, Aurelien Jarno wrote: > > Use bits32 instead of uint32 when manipulating floating point values > > directly for consistency reasons. > > I'm not convinced this patch is particularly worthwhile, especially si

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno wrote: > Use bits32 instead of uint32 when manipulating floating point values > directly for consistency reasons. I'm not convinced this patch is particularly worthwhile, especially since Andreas is working on a patchset which will convert all the bits32 us

[Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Aurelien Jarno
Use bits32 instead of uint32 when manipulating floating point values directly for consistency reasons. Signed-off-by: Aurelien Jarno --- fpu/softfloat-native.c |4 ++-- fpu/softfloat-specialize.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat-