[Qemu-devel] [PATCH v2 2/9] softmmu: provide softmmu access type enum

2014-07-08 Thread Leon Alrae
New MIPS features depend on the access type and enum is more convenient than using the numbers directly. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- include/exec/cpu-common.h |6 ++ softmmu_template.h| 26 -- 2 files changed, 22 insertions(+), 10

Re: [Qemu-devel] [PATCH v2 2/9] softmmu: provide softmmu access type enum

2014-07-08 Thread Peter Maydell
On 8 July 2014 08:57, Leon Alrae leon.al...@imgtec.com wrote: New MIPS features depend on the access type and enum is more convenient than using the numbers directly. Mmm, I've thought for a while it would be better to have this be an enum, but never got round to it. Signed-off-by: Leon Alrae

Re: [Qemu-devel] [PATCH v2 2/9] softmmu: provide softmmu access type enum

2014-07-08 Thread Leon Alrae
Hi Peter, On 08/07/2014 14:00, Peter Maydell wrote: On 8 July 2014 08:57, Leon Alrae leon.al...@imgtec.com wrote: New MIPS features depend on the access type and enum is more convenient than using the numbers directly. Mmm, I've thought for a while it would be better to have this be an

Re: [Qemu-devel] [PATCH v2 2/9] softmmu: provide softmmu access type enum

2014-07-08 Thread Peter Maydell
On 8 July 2014 17:08, Leon Alrae leon.al...@imgtec.com wrote: I intentionally skipped this here to focus this patchset on the new features only. I also think that eventually we will have to update the prototypes and go through all the targets. Yeah, that's reasonable. If you make this a