Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2019-01-07 Thread Eric Blake
On 1/7/19 3:54 AM, Gerd Hoffmann wrote: >> The first one is fixable with an explicit cast (ugly but works), but the >> second one is more problematic. It means we can't write stuff like >> >> USBPort uports[MAX(MAXPORTS_2, MAXPORTS_3)]; >> >> when not in a function. So we either need a dumb

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2019-01-07 Thread Gerd Hoffmann
> The first one is fixable with an explicit cast (ugly but works), but the > second one is more problematic. It means we can't write stuff like > > USBPort uports[MAX(MAXPORTS_2, MAXPORTS_3)]; > > when not in a function. So we either need a dumb version of MIN/MAX, or > scrape the idea

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-27 Thread Kővágó Zoltán
On 2018-12-25 11:40, Philippe Mathieu-Daudé wrote: > On 12/24/18 9:48 PM, Kővágó Zoltán wrote: >> On 2018-12-24 18:16, Philippe Mathieu-Daudé wrote: >>> On 12/24/18 3:16 AM, Zoltán Kővágó wrote: Hi Phil, On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: > Hi Zoltán, > >

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-25 Thread Philippe Mathieu-Daudé
On 12/24/18 9:48 PM, Kővágó Zoltán wrote: > On 2018-12-24 18:16, Philippe Mathieu-Daudé wrote: >> On 12/24/18 3:16 AM, Zoltán Kővágó wrote: >>> Hi Phil, >>> >>> On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: Hi Zoltán, On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: > There's

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-24 Thread Kővágó Zoltán
On 2018-12-24 18:16, Philippe Mathieu-Daudé wrote: > On 12/24/18 3:16 AM, Zoltán Kővágó wrote: >> Hi Phil, >> >> On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: >>> Hi Zoltán, >>> >>> On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: There's already a MIN and MAX macro in include/qemu/osdep.h,

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-24 Thread Philippe Mathieu-Daudé
On 12/24/18 3:16 AM, Zoltán Kővágó wrote: > Hi Phil, > > On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: >> Hi Zoltán, >> >> On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: >>> There's already a MIN and MAX macro in include/qemu/osdep.h, use them >>> instead. >>> >>> Signed-off-by: Kővágó, Zoltán

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-23 Thread Zoltán Kővágó
Hi Phil, On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote: > Hi Zoltán, > > On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: >> There's already a MIN and MAX macro in include/qemu/osdep.h, use them >> instead. >> >> Signed-off-by: Kővágó, Zoltán >> >> --- >> >> Changes from v1: >> * removed

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-23 Thread Philippe Mathieu-Daudé
Hi Zoltán, On 12/23/18 9:51 PM, Kővágó, Zoltán wrote: > There's already a MIN and MAX macro in include/qemu/osdep.h, use them > instead. > > Signed-off-by: Kővágó, Zoltán > > --- > > Changes from v1: > * removed audio_MIN, audio_MAX macros > --- [...]> > diff --git a/audio/audio.h

[Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2018-12-23 Thread Kővágó, Zoltán
There's already a MIN and MAX macro in include/qemu/osdep.h, use them instead. Signed-off-by: Kővágó, Zoltán --- Changes from v1: * removed audio_MIN, audio_MAX macros --- audio/alsaaudio.c | 6 +++--- audio/audio.c | 20 ++-- audio/audio.h |