Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread H. Peter Anvin
On 12/06/2013 05:16 PM, Ren, Qiaowei wrote: > Jinsong think that both kvm and host depend on these feature definition > header file, so we firstly submit these files depended on. Yes, but we can't turn on the feature without proper protection. Either way, they are now in tip:x86/cpufeature.

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
l.org; Ingo Molnar; Thomas > Gleixner > Subject: Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature > definition > > On 12/06/2013 04:23 PM, Ren, Qiaowei wrote: > >>> > >>> We need to either disable these features in lazy mode, or we need to >

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread H. Peter Anvin
On 12/06/2013 04:23 PM, Ren, Qiaowei wrote: >>> >>> We need to either disable these features in lazy mode, or we need to >>> force eager mode if these features are to be supported. The problem >>> with the latter is that it means forcing eager mode regardless of if >>> anything actually *uses* the

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
t; Gleixner > Subject: RE: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature > definition > > H. Peter Anvin wrote: > > On 12/06/2013 12:05 PM, Liu, Jinsong wrote: > >>> > >>> Since Peter already said the same, please undo these changes. >

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Liu, Jinsong
H. Peter Anvin wrote: > On 12/06/2013 12:05 PM, Liu, Jinsong wrote: >>> >>> Since Peter already said the same, please undo these changes. >>> >>> Also, how is XSTATE_EAGER used? Should MPX be disabled when >>> xsaveopt is disabled on the kernel command line? (Liu, how would >>> this affect the

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread H. Peter Anvin
On 12/06/2013 12:05 PM, Liu, Jinsong wrote: >> >> Since Peter already said the same, please undo these changes. >> >> Also, how is XSTATE_EAGER used? Should MPX be disabled when xsaveopt >> is disabled on the kernel command line? (Liu, how would this affect >> the KVM patches, too?) >> >> Paolo >

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Liu, Jinsong
Paolo Bonzini wrote: > Il 07/12/2013 01:20, Qiaowei Ren ha scritto: >> This patch defines xstate feature and extends struct xsave_hdr_struct >> to support Intel MPX. >> >> Signed-off-by: Qiaowei Ren >> Signed-off-by: Xudong Hao >> Signed-off-by: Liu Jinsong >> --- >> arch/x86/include/asm/proce

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread H. Peter Anvin
On 12/06/2013 09:35 AM, Paolo Bonzini wrote: > > Sorry for the back-and-forth, but I think this and the removal of > XSTATE_FLEXIBLE (perhaps XSTATE_LAZY?) makes your v2 worse than v1. > > Since Peter already said the same, please undo these changes. > > Also, how is XSTATE_EAGER used? Should M

Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Paolo Bonzini
Il 07/12/2013 01:20, Qiaowei Ren ha scritto: > This patch defines xstate feature and extends struct xsave_hdr_struct > to support Intel MPX. > > Signed-off-by: Qiaowei Ren > Signed-off-by: Xudong Hao > Signed-off-by: Liu Jinsong > --- > arch/x86/include/asm/processor.h | 12 > a

[Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Qiaowei Ren
This patch defines xstate feature and extends struct xsave_hdr_struct to support Intel MPX. Signed-off-by: Qiaowei Ren Signed-off-by: Xudong Hao Signed-off-by: Liu Jinsong --- arch/x86/include/asm/processor.h | 12 arch/x86/include/asm/xsave.h |5 - 2 files changed,