Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-06 Thread Peter Xu
On Fri, Mar 04, 2016 at 09:43:24AM +0100, Andrea Bolognani wrote: > On Fri, 2016-03-04 at 10:52 +0800, Peter Xu wrote: > > Andrea, do you know how much effort we need to add this support for > > libvirt, say, we can specify "accel=" or "-enable-kvm" as extra > > parameter when probing? > > I'm

Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-04 Thread Andrea Bolognani
On Fri, 2016-03-04 at 10:52 +0800, Peter Xu wrote: > > Sorry for not catching this earlier, but I'm afraid this is not > > going to work -- libvirt doesn't pass either -enable-kvm or the > > machine option accel=kvm when probing for capabilities, which > > means that, with the current

Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-03 Thread Peter Xu
On Thu, Mar 03, 2016 at 01:19:47PM +0100, Andrea Bolognani wrote: > On Thu, 2016-03-03 at 16:21 +0800, Peter Xu wrote: > > For emulated ARM VM, only gicv2 is supported. We need to add gicv3 > in > > when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the > > capability bits using

Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-03 Thread Andrea Bolognani
On Thu, 2016-03-03 at 16:21 +0800, Peter Xu wrote: > For emulated ARM VM, only gicv2 is supported. We need to add gicv3 in > when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the > capability bits using ioctls. >  > if we want to know GIC kernel capabilities, we need to make sure we

[Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-03 Thread Peter Xu
For emulated ARM VM, only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits using ioctls. if we want to know GIC kernel capabilities, we need to make sure we have enabled KVM when querying (like, with "-enable-kvm").