Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-08 Thread Cornelia Huck
On Fri, 4 Jan 2019 14:17:14 -0600 Eric Blake wrote: > On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote: > > Many functions have documentation before the implementation in > > cutils.c. Since we expect documentation around the prototype > > declaration in headers, move the comments in cutils.h. >

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-07 Thread Markus Armbruster
Eric Blake writes: > On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote: >> Many functions have documentation before the implementation in >> cutils.c. Since we expect documentation around the prototype >> declaration in headers, move the comments in cutils.h. >> >> Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-07 Thread Stefano Garzarella
On Fri, Jan 4, 2019 at 7:13 PM Philippe Mathieu-Daudé wrote: > > Many functions have documentation before the implementation in > cutils.c. Since we expect documentation around the prototype > declaration in headers, move the comments in cutils.h. > > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-06 Thread David Gibson
On Fri, Jan 04, 2019 at 07:12:08PM +0100, Philippe Mathieu-Daudé wrote: > Many functions have documentation before the implementation in > cutils.c. Since we expect documentation around the prototype > declaration in headers, move the comments in cutils.h. > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-04 Thread Eric Blake
On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote: > Many functions have documentation before the implementation in > cutils.c. Since we expect documentation around the prototype > declaration in headers, move the comments in cutils.h. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

[Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-04 Thread Philippe Mathieu-Daudé
Many functions have documentation before the implementation in cutils.c. Since we expect documentation around the prototype declaration in headers, move the comments in cutils.h. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cutils.h | 224 ++