Re: [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed

2015-08-06 Thread Marc-André Lureau
Hi On Mon, Jun 22, 2015 at 5:50 AM, Tetsuya Mukawa wrote: > When wrong vhost-user message are passed, the connection should be shutdown. > > Signed-off-by: Tetsuya Mukawa > --- > hw/virtio/vhost-user.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed

2015-06-23 Thread Tetsuya Mukawa
On 2015/06/22 16:54, Michael S. Tsirkin wrote: > On Mon, Jun 22, 2015 at 12:50:46PM +0900, Tetsuya Mukawa wrote: >> When wrong vhost-user message are passed, the connection should be shutdown. >> >> Signed-off-by: Tetsuya Mukawa > This silently changes the protocol semantics: previously > unknown

Re: [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed

2015-06-22 Thread Michael S. Tsirkin
On Mon, Jun 22, 2015 at 12:50:46PM +0900, Tetsuya Mukawa wrote: > When wrong vhost-user message are passed, the connection should be shutdown. > > Signed-off-by: Tetsuya Mukawa This silently changes the protocol semantics: previously unknown messages were ignored. We can't do this. See email tit

[Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed

2015-06-21 Thread Tetsuya Mukawa
When wrong vhost-user message are passed, the connection should be shutdown. Signed-off-by: Tetsuya Mukawa --- hw/virtio/vhost-user.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index d6f2163..2215c39 100