Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-11 Thread Marc-André Lureau
Hi On Mon, Feb 11, 2019 at 11:27 AM Peter Xu wrote: > > On Mon, Feb 11, 2019 at 10:57:01AM +0100, Marc-André Lureau wrote: > > Hi > > > > On Mon, Feb 11, 2019 at 8:13 AM Peter Xu wrote: > > > > > > On Thu, Feb 07, 2019 at 06:14:15PM +0100, Cornelia Huck wrote: > > > > On Wed, 6 Feb 2019

Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-11 Thread Peter Xu
On Mon, Feb 11, 2019 at 10:57:01AM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Feb 11, 2019 at 8:13 AM Peter Xu wrote: > > > > On Thu, Feb 07, 2019 at 06:14:15PM +0100, Cornelia Huck wrote: > > > On Wed, 6 Feb 2019 18:43:25 +0100 > > > Marc-André Lureau wrote: > > > > > > > terminal3270

Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-11 Thread Marc-André Lureau
Hi On Mon, Feb 11, 2019 at 8:13 AM Peter Xu wrote: > > On Thu, Feb 07, 2019 at 06:14:15PM +0100, Cornelia Huck wrote: > > On Wed, 6 Feb 2019 18:43:25 +0100 > > Marc-André Lureau wrote: > > > > > terminal3270 uses the front-end side of the chardev. It shouldn't > > > create sources from backend

Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-10 Thread Peter Xu
On Thu, Feb 07, 2019 at 06:14:15PM +0100, Cornelia Huck wrote: > On Wed, 6 Feb 2019 18:43:25 +0100 > Marc-André Lureau wrote: > > > terminal3270 uses the front-end side of the chardev. It shouldn't > > create sources from backend side context (with backend > > functions). > > > >

Re: [Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-07 Thread Cornelia Huck
On Wed, 6 Feb 2019 18:43:25 +0100 Marc-André Lureau wrote: > terminal3270 uses the front-end side of the chardev. It shouldn't > create sources from backend side context (with backend > functions). > > send_timing_mark_cb calls qemu_chr_fe_write_all() which should be > thread safe. > > This

[Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-06 Thread Marc-André Lureau
terminal3270 uses the front-end side of the chardev. It shouldn't create sources from backend side context (with backend functions). send_timing_mark_cb calls qemu_chr_fe_write_all() which should be thread safe. This partially reverts changes from commit 2c716ba1506769c9be2caa02f0f6d6e7c00f4304.