Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-02-03 Thread Richard Henderson
On 01/30/2015 08:02 AM, Maciej W. Rozycki wrote: > Hmm, so perhaps my idea for a later improvement: > >> > Eventually we might want to move the new inline functions into a >> > separate header to be included from softfloat.h instead of softfloat.c, >> > but let's make changes one step at a time.

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-31 Thread Maciej W. Rozycki
On Sat, 31 Jan 2015, Peter Maydell wrote: > >> > Hmm, so perhaps my idea for a later improvement: > >> > > >> >> Eventually we might want to move the new inline functions into a > >> >> separate header to be included from softfloat.h instead of softfloat.c, > >> >> but let's make changes one ste

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-31 Thread Peter Maydell
On 31 January 2015 at 11:56, Maciej W. Rozycki wrote: > On Fri, 30 Jan 2015, Peter Maydell wrote: > >> > Hmm, so perhaps my idea for a later improvement: >> > >> >> Eventually we might want to move the new inline functions into a >> >> separate header to be included from softfloat.h instead of s

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-31 Thread Maciej W. Rozycki
On Fri, 30 Jan 2015, Peter Maydell wrote: > > Hmm, so perhaps my idea for a later improvement: > > > >> Eventually we might want to move the new inline functions into a > >> separate header to be included from softfloat.h instead of softfloat.c, > >> but let's make changes one step at a time. >

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 16:02, Maciej W. Rozycki wrote: > Hmm, so perhaps my idea for a later improvement: > >> Eventually we might want to move the new inline functions into a >> separate header to be included from softfloat.h instead of softfloat.c, >> but let's make changes one step at a time.

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-30 Thread Maciej W. Rozycki
On Fri, 30 Jan 2015, Leon Alrae wrote: > > @@ -760,6 +760,6 @@ static inline int float128_is_any_nan(fl > > > > /* > > | The pattern for a default generated quadruple-precision NaN. > > > > *--

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-30 Thread Leon Alrae
On 12/12/2014 19:34, Maciej W. Rozycki wrote: > Mechanically replace `*_default_nan' variables with inline functions and > convert references accordingly. Use `__inline__' rather than `inline' > so that the latter does not cause the definitions to become static as a > result of macro expansion,

[Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2014-12-12 Thread Maciej W. Rozycki
Mechanically replace `*_default_nan' variables with inline functions and convert references accordingly. Use `__inline__' rather than `inline' so that the latter does not cause the definitions to become static as a result of macro expansion, the functions are best inlined when referred to from