Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Halil Pasic
On 10/12/2017 02:11 PM, Cornelia Huck wrote: > On Thu, 12 Oct 2017 14:06:42 +0200 > Halil Pasic wrote: > >> On 10/10/2017 04:36 PM, Halil Pasic wrote: >>> >>> >>> On 10/10/2017 03:07 PM, Cornelia Huck wrote: On Wed, 4 Oct 2017 17:41:39 +0200 Halil Pasic wrote: > Simplif

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Cornelia Huck
On Thu, 12 Oct 2017 14:06:42 +0200 Halil Pasic wrote: > On 10/10/2017 04:36 PM, Halil Pasic wrote: > > > > > > On 10/10/2017 03:07 PM, Cornelia Huck wrote: > >> On Wed, 4 Oct 2017 17:41:39 +0200 > >> Halil Pasic wrote: > >> > >>> Simplify the error handling of the SSCH and RSCH handler av

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Halil Pasic
On 10/10/2017 04:36 PM, Halil Pasic wrote: > > > On 10/10/2017 03:07 PM, Cornelia Huck wrote: >> On Wed, 4 Oct 2017 17:41:39 +0200 >> Halil Pasic wrote: >> >>> Simplify the error handling of the SSCH and RSCH handler avoiding >>> arbitrary and cryptic error codes being used to tell how the in

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-11 Thread Dong Jia Shi
* Halil Pasic [2017-10-11 12:54:51 +0200]: > > > On 10/11/2017 05:47 AM, Dong Jia Shi wrote: > > * Halil Pasic [2017-10-04 17:41:39 +0200]: > > > >> Simplify the error handling of the SSCH and RSCH handler avoiding > >> arbitrary and cryptic error codes being used to tell how the instruction

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-11 Thread Halil Pasic
On 10/11/2017 05:47 AM, Dong Jia Shi wrote: > * Halil Pasic [2017-10-04 17:41:39 +0200]: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the instruction >> is supposed to end. Let the code detecting the conditio

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Dong Jia Shi
* Halil Pasic [2017-10-10 12:06:23 +0200]: > > > On 10/10/2017 10:13 AM, Dong Jia Shi wrote: > > * Halil Pasic [2017-10-04 17:41:39 +0200]: > > > > [...] > > > >> diff --git a/hw/s390x/css.c b/hw/s390x/css.c > >> index 4f47dbc8b0..b2978c3bae 100644 > >> --- a/hw/s390x/css.c > >> +++ b/hw/s39

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Dong Jia Shi
* Halil Pasic [2017-10-04 17:41:39 +0200]: > Simplify the error handling of the SSCH and RSCH handler avoiding > arbitrary and cryptic error codes being used to tell how the instruction > is supposed to end. Let the code detecting the condition tell how it's > to be handled in a less ambiguous w

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Halil Pasic
On 10/10/2017 03:07 PM, Cornelia Huck wrote: > On Wed, 4 Oct 2017 17:41:39 +0200 > Halil Pasic wrote: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the instruction >> is supposed to end. Let the code detectin

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Cornelia Huck
On Wed, 4 Oct 2017 17:41:39 +0200 Halil Pasic wrote: > Simplify the error handling of the SSCH and RSCH handler avoiding > arbitrary and cryptic error codes being used to tell how the instruction > is supposed to end. Let the code detecting the condition tell how it's > to be handled in a less

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Halil Pasic
On 10/10/2017 10:13 AM, Dong Jia Shi wrote: > * Halil Pasic [2017-10-04 17:41:39 +0200]: > > [...] > >> diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> index 4f47dbc8b0..b2978c3bae 100644 >> --- a/hw/s390x/css.c >> +++ b/hw/s390x/css.c >> @@ -1003,12 +1003,11 @@ static void sch_handle_start_fu

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-10 Thread Dong Jia Shi
* Halil Pasic [2017-10-04 17:41:39 +0200]: [...] > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > index 4f47dbc8b0..b2978c3bae 100644 > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -1003,12 +1003,11 @@ static void sch_handle_start_func_virtual(SubchDev > *sch) > > } > > -static int sch_h

[Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-04 Thread Halil Pasic
Simplify the error handling of the SSCH and RSCH handler avoiding arbitrary and cryptic error codes being used to tell how the instruction is supposed to end. Let the code detecting the condition tell how it's to be handled in a less ambiguous way. It's best to handle SSCH and RSCH in one go as t