Re: [Qemu-devel] [PATCH v2 35/41] postcopy: introduce helper functions for postcopy

2012-06-16 Thread Juan Quintela
Isaku Yamahata wrote: > On Thu, Jun 14, 2012 at 11:34:09PM +0200, Juan Quintela wrote: >> > +size_t umem_pages_size(uint64_t nr) >> > +{ >> > +return sizeof(struct umem_pages) + nr * sizeof(uint64_t); >> >> Can we make sure that the pgoffs field is aligned? I know that as it is >> now it is

Re: [Qemu-devel] [PATCH v2 35/41] postcopy: introduce helper functions for postcopy

2012-06-16 Thread Isaku Yamahata
On Thu, Jun 14, 2012 at 11:34:09PM +0200, Juan Quintela wrote: > Isaku Yamahata wrote: > > +//#define DEBUG_UMEM > > +#ifdef DEBUG_UMEM > > +#include > > +#define DPRINTF(format, ...)\ > > +do {

Re: [Qemu-devel] [PATCH v2 35/41] postcopy: introduce helper functions for postcopy

2012-06-14 Thread Juan Quintela
Isaku Yamahata wrote: > +//#define DEBUG_UMEM > +#ifdef DEBUG_UMEM > +#include > +#define DPRINTF(format, ...)\ > +do {\ > +printf("%d:%ld %s:%d "format, getpid(), syscall(SYS_g

[Qemu-devel] [PATCH v2 35/41] postcopy: introduce helper functions for postcopy

2012-06-04 Thread Isaku Yamahata
This patch introduces helper function for postcopy to access umem char device and to communicate between incoming-qemu and umemd. Signed-off-by: Isaku Yamahata --- changes v1 -> v2: - code simplification - make fault trigger more robust - introduce struct umem_pages --- umem.c | 364 +++