Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-09-02 Thread Kevin Wolf
Am 03.08.2011 15:08, schrieb Markus Armbruster: Need to ask the device, so this requires new BlockDevOps member is_medium_ejected(). Signed-off-by: Markus Armbruster arm...@redhat.com I find the name confusing. medium is ejected seems to mean tray is open. It isn't obvious that tray is

Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-09-02 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 03.08.2011 15:08, schrieb Markus Armbruster: Need to ask the device, so this requires new BlockDevOps member is_medium_ejected(). Signed-off-by: Markus Armbruster arm...@redhat.com I find the name confusing. medium is ejected seems to mean tray is

Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-09-02 Thread Kevin Wolf
Am 02.09.2011 17:29, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 03.08.2011 15:08, schrieb Markus Armbruster: Need to ask the device, so this requires new BlockDevOps member is_medium_ejected(). Signed-off-by: Markus Armbruster arm...@redhat.com I find the name

Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-08-04 Thread Luiz Capitulino
On Wed, 3 Aug 2011 15:08:16 +0200 Markus Armbruster arm...@redhat.com wrote: Need to ask the device, so this requires new BlockDevOps member is_medium_ejected(). Signed-off-by: Markus Armbruster arm...@redhat.com Looks good to me. --- block.c | 17 +++-- block.h

[Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block

2011-08-03 Thread Markus Armbruster
Need to ask the device, so this requires new BlockDevOps member is_medium_ejected(). Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 17 +++-- block.h |6 ++ hw/ide/core.c |6 ++ hw/scsi-disk.c |6 ++ qmp-commands.hx |