Re: [Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

2018-01-18 Thread Daniel P. Berrange
On Wed, Nov 01, 2017 at 02:25:26PM +, Ross Lagerwall wrote: > Add /dev/fdset/ support to QIOChannelFile by calling qemu_open() instead > of open() and qemu_close() instead of close(). There is a subtle > semantic change since qemu_open() automatically sets O_CLOEXEC, but this > doesn't affect a

Re: [Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

2017-11-01 Thread Marc-André Lureau
On Wed, Nov 1, 2017 at 3:25 PM, Ross Lagerwall wrote: > Add /dev/fdset/ support to QIOChannelFile by calling qemu_open() instead > of open() and qemu_close() instead of close(). There is a subtle > semantic change since qemu_open() automatically sets O_CLOEXEC, but this > doesn't affect any of the

[Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

2017-11-01 Thread Ross Lagerwall
Add /dev/fdset/ support to QIOChannelFile by calling qemu_open() instead of open() and qemu_close() instead of close(). There is a subtle semantic change since qemu_open() automatically sets O_CLOEXEC, but this doesn't affect any of the users of the function. Signed-off-by: Ross Lagerwall --- Cha