Re: [Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-29 Thread David Hildenbrand
On 29.06.2018 17:08, Igor Mammedov wrote: > On Thu, 28 Jun 2018 14:14:17 +0200 > David Hildenbrand wrote: > >> We can assign and verify the slot before realizing and trying to plug. >> reading/writing the address property should never fail, so let's reduce >> error handling a bit by using &error_

Re: [Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-29 Thread Igor Mammedov
On Fri, 29 Jun 2018 09:14:52 +0200 David Hildenbrand wrote: > On 29.06.2018 03:19, David Gibson wrote: > > On Thu, Jun 28, 2018 at 02:14:17PM +0200, David Hildenbrand wrote: > >> We can assign and verify the slot before realizing and trying to plug. > >> reading/writing the address property sho

Re: [Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-29 Thread Igor Mammedov
On Thu, 28 Jun 2018 14:14:17 +0200 David Hildenbrand wrote: > We can assign and verify the slot before realizing and trying to plug. > reading/writing the address property should never fail, so let's reduce > error handling a bit by using &error_abort. Getting access to the memory > region now mi

Re: [Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-29 Thread David Hildenbrand
On 29.06.2018 03:19, David Gibson wrote: > On Thu, Jun 28, 2018 at 02:14:17PM +0200, David Hildenbrand wrote: >> We can assign and verify the slot before realizing and trying to plug. >> reading/writing the address property should never fail, so let's reduce >> error handling a bit by using &error_

Re: [Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-28 Thread David Gibson
On Thu, Jun 28, 2018 at 02:14:17PM +0200, David Hildenbrand wrote: > We can assign and verify the slot before realizing and trying to plug. > reading/writing the address property should never fail, so let's reduce > error handling a bit by using &error_abort. Getting access to the memory > region n

[Qemu-devel] [PATCH v2 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-06-28 Thread David Hildenbrand
We can assign and verify the slot before realizing and trying to plug. reading/writing the address property should never fail, so let's reduce error handling a bit by using &error_abort. Getting access to the memory region now might however fail. So forward errors from get_memory_region() properly.