Re: [Qemu-devel] [PATCH v2 4/4] qemu-char: do not operate on sources from finalize callbacks

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 5:32:09 PM, you wrote: > Due to a glib bug, the finalize callback is called with the GMainContext > lock held. Thus, any operation on the context from the callback will > cause recursive locking and a deadlock. This happens, for example, > when a client disconnects from

[Qemu-devel] [PATCH v2 4/4] qemu-char: do not operate on sources from finalize callbacks

2013-04-19 Thread Paolo Bonzini
Due to a glib bug, the finalize callback is called with the GMainContext lock held. Thus, any operation on the context from the callback will cause recursive locking and a deadlock. This happens, for example, when a client disconnects from a socket chardev. The fix for this is somewhat ugly, bec