Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 14:04:03 +0200]: I have no problem with the rest parts of the discussion in this thread. > > > On 09/19/2017 12:57 PM, Cornelia Huck wrote: > > +static inline int ida_read_next_idaw(CcwDataStream *cds) > > +{ > > +union {uint64_t fmt2; uint32_t fmt1; }

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:05:48 +0200]: > > > On 09/19/2017 02:23 PM, Cornelia Huck wrote: > > +{ > > +union {uint64_t fmt2; uint32_t fmt1; } idaw; > ^ > Nit. > > >> Maybe checkpatch wanted it this way. My memori

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Halil Pasic
On 09/19/2017 02:23 PM, Cornelia Huck wrote: > +{ > +union {uint64_t fmt2; uint32_t fmt1; } idaw; ^ Nit. >> Maybe checkpatch wanted it this way. My memories are blurry. > I'd just leave it like that, tbh. Yes, if I

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Halil Pasic
On 09/19/2017 03:46 PM, Pierre Morel wrote: > On 19/09/2017 12:57, Cornelia Huck wrote: >> On Tue, 19 Sep 2017 12:36:33 +0200 >> Halil Pasic wrote: >> >>> On 09/19/2017 11:48 AM, Cornelia Huck wrote: On Tue, 19 Sep 2017 13:50:05 +0800 Dong Jia Shi wrote:    > * Halil Pasic [

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 14:32:33 +0200 Halil Pasic wrote: > On 09/19/2017 02:23 PM, Cornelia Huck wrote: > > On Tue, 19 Sep 2017 14:04:03 +0200 > > Halil Pasic wrote: > > > >> On 09/19/2017 12:57 PM, Cornelia Huck wrote: > >>> +static inline int ida_read_next_idaw(CcwDataStream *cds) >

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Pierre Morel
On 19/09/2017 12:57, Cornelia Huck wrote: On Tue, 19 Sep 2017 12:36:33 +0200 Halil Pasic wrote: On 09/19/2017 11:48 AM, Cornelia Huck wrote: On Tue, 19 Sep 2017 13:50:05 +0800 Dong Jia Shi wrote: * Halil Pasic [2017-09-13 13:50:29 +0200]: Let's add indirect data addressing support

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Halil Pasic
On 09/19/2017 02:23 PM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 14:04:03 +0200 > Halil Pasic wrote: > >> On 09/19/2017 12:57 PM, Cornelia Huck wrote: >>> +static inline int ida_read_next_idaw(CcwDataStream *cds) >>> +{ >>> +union {uint64_t fmt2; uint32_t fmt1; } idaw; >

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 14:04:03 +0200 Halil Pasic wrote: > On 09/19/2017 12:57 PM, Cornelia Huck wrote: > > +static inline int ida_read_next_idaw(CcwDataStream *cds) > > +{ > > +union {uint64_t fmt2; uint32_t fmt1; } idaw; > ^ > >

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Halil Pasic
On 09/19/2017 12:57 PM, Cornelia Huck wrote: > +static inline int ida_read_next_idaw(CcwDataStream *cds) > +{ > +union {uint64_t fmt2; uint32_t fmt1; } idaw; ^ Nit. >> Maybe checkpatch wanted it this way. My memories

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 12:36:33 +0200 Halil Pasic wrote: > On 09/19/2017 11:48 AM, Cornelia Huck wrote: > > On Tue, 19 Sep 2017 13:50:05 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-09-13 13:50:29 +0200]: > >> > >>> Let's add indirect data addressing support for our virtual chan

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Halil Pasic
On 09/19/2017 11:48 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 13:50:05 +0800 > Dong Jia Shi wrote: > >> * Halil Pasic [2017-09-13 13:50:29 +0200]: >> >>> Let's add indirect data addressing support for our virtual channel >>> subsystem. This implementation does no bother with any kind of >

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Cornelia Huck
On Tue, 19 Sep 2017 13:50:05 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-13 13:50:29 +0200]: > > > Let's add indirect data addressing support for our virtual channel > > subsystem. This implementation does no bother with any kind of > > prefetching. We simply step trough the IDAL on dema

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-13 13:50:29 +0200]: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does no bother with any kind of > prefetching. We simply step trough the IDAL on demand. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 109

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:29 +0200 Halil Pasic wrote: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does no bother with any kind of s/no/not/ > prefetching. We simply step trough the IDAL on demand. s/trough/through/ > > Signed-off-by:

[Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-13 Thread Halil Pasic
Let's add indirect data addressing support for our virtual channel subsystem. This implementation does no bother with any kind of prefetching. We simply step trough the IDAL on demand. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 109 -