Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-04 Thread Auger Eric
Hi Alex, On 05/03/2018 06:29 PM, Alex Williamson wrote: > On Thu, 3 May 2018 12:56:03 +0800 > Peter Xu wrote: > >> On Tue, May 01, 2018 at 10:43:46AM -0600, Alex Williamson wrote: >> >> [...] >> >>> -static void vfio_ioeventfd_exit(VFIOIOEventFD *ioeventfd) >>> +static void vfio_ioeventfd_exit(V

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-03 Thread Peter Xu
On Thu, May 03, 2018 at 10:29:42AM -0600, Alex Williamson wrote: > On Thu, 3 May 2018 12:56:03 +0800 > Peter Xu wrote: > > > On Tue, May 01, 2018 at 10:43:46AM -0600, Alex Williamson wrote: > > > > [...] > > > > > -static void vfio_ioeventfd_exit(VFIOIOEventFD *ioeventfd) > > > +static void vfi

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-03 Thread Alex Williamson
On Thu, 3 May 2018 17:20:18 +0200 Auger Eric wrote: > Hi Alex, > > On 05/01/2018 06:43 PM, Alex Williamson wrote: > > With vfio ioeventfd support, we can program vfio-pci to perform a > > specified BAR write when an eventfd is triggered. This allows the > > KVM ioeventfd to be wired directly to

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-03 Thread Alex Williamson
On Thu, 3 May 2018 12:56:03 +0800 Peter Xu wrote: > On Tue, May 01, 2018 at 10:43:46AM -0600, Alex Williamson wrote: > > [...] > > > -static void vfio_ioeventfd_exit(VFIOIOEventFD *ioeventfd) > > +static void vfio_ioeventfd_exit(VFIOPCIDevice *vdev, VFIOIOEventFD > > *ioeventfd) > > { > >

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-03 Thread Auger Eric
Hi Alex, On 05/01/2018 06:43 PM, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for these events

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-02 Thread Peter Xu
On Tue, May 01, 2018 at 10:43:46AM -0600, Alex Williamson wrote: [...] > -static void vfio_ioeventfd_exit(VFIOIOEventFD *ioeventfd) > +static void vfio_ioeventfd_exit(VFIOPCIDevice *vdev, VFIOIOEventFD > *ioeventfd) > { > QLIST_REMOVE(ioeventfd, next); > + > memory_region_del_eventfd(

[Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-01 Thread Alex Williamson
With vfio ioeventfd support, we can program vfio-pci to perform a specified BAR write when an eventfd is triggered. This allows the KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding userspace handling for these events. On the same micro-benchmark where the ioeventfd got us to almo