Re: [Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-15 Thread Gabriel L. Somlo
On Tue, Sep 15, 2015 at 02:51:31PM +0100, Peter Maydell wrote: > On 15 September 2015 at 14:42, Gabriel L. Somlo wrote: > > On Tue, Sep 15, 2015 at 10:06:45AM +0800, Shannon Zhao wrote: > >> This looks fine to me. But from what you said, the kernel driver is not > >> in upstream kernel yet, so thi

Re: [Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-15 Thread Peter Maydell
On 15 September 2015 at 14:42, Gabriel L. Somlo wrote: > On Tue, Sep 15, 2015 at 10:06:45AM +0800, Shannon Zhao wrote: >> This looks fine to me. But from what you said, the kernel driver is not >> in upstream kernel yet, so this would be applied after the kernel patch >> applied in case of unexpec

Re: [Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-15 Thread Gabriel L. Somlo
On Tue, Sep 15, 2015 at 10:06:45AM +0800, Shannon Zhao wrote: > > > On 2015/9/14 22:57, Gabriel L. Somlo wrote: > > Add a fw_cfg device node to the ACPI DSDT. This is mostly > > informational, as the authoritative fw_cfg MMIO region(s) > > are listed in the Device Tree. However, since we are buil

Re: [Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-14 Thread Shannon Zhao
On 2015/9/14 22:57, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI DSDT. This is mostly > informational, as the authoritative fw_cfg MMIO region(s) > are listed in the Device Tree. However, since we are building > ACPI tables, we might as well be thorough while at it... > > Signe

[Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-14 Thread Gabriel L. Somlo
Add a fw_cfg device node to the ACPI DSDT. This is mostly informational, as the authoritative fw_cfg MMIO region(s) are listed in the Device Tree. However, since we are building ACPI tables, we might as well be thorough while at it... Signed-off-by: Gabriel Somlo --- hw/arm/virt-acpi-build.c | 1