Re: [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount

2018-11-08 Thread Richard Henderson
On 11/8/18 5:33 PM, Alex Bennée wrote: > @@ -16,6 +16,7 @@ def report(cond, msg): > print ("PASS: %s" % (msg)) > else: > print ("FAIL: %s" % (msg)) > +global failcount > failcount += 1 Do we usually prefer such declarations at the start of the function? Anyw

[Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount

2018-11-08 Thread Alex Bennée
You should declare you are using a global version of a variable before you attempt to modify it in a function. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell --- tests/guest-debug/test-gdbstub.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/guest-debug/test-gdbstub.py b/tes