Re: [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend

2016-09-29 Thread Fam Zheng
On Thu, 09/29 09:47, Paolo Bonzini wrote: > > > On 29/09/2016 05:05, Fam Zheng wrote: > > > So whether we can move a certain BB from some context to another depends > > > on what the frontend supports, I don't think there is a generic answer > > > we can implement here in the generic BB code. NBD

Re: [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend

2016-09-29 Thread Paolo Bonzini
On 29/09/2016 05:05, Fam Zheng wrote: > > So whether we can move a certain BB from some context to another depends > > on what the frontend supports, I don't think there is a generic answer > > we can implement here in the generic BB code. NBD for instance allows > > any movement; but devices pro

Re: [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend

2016-09-28 Thread Fam Zheng
On Wed, 09/28 19:47, Max Reitz wrote: > On 27.09.2016 08:37, Fam Zheng wrote: > > From: Stefan Hajnoczi > > > > blk_get/set_aio_context() delegate to BlockDriverState without storing > > the AioContext pointer in BlockBackend. > > > > There are two flaws: > > > > 1. BlockBackend falls back to t

Re: [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend

2016-09-28 Thread Max Reitz
On 27.09.2016 08:37, Fam Zheng wrote: > From: Stefan Hajnoczi > > blk_get/set_aio_context() delegate to BlockDriverState without storing > the AioContext pointer in BlockBackend. > > There are two flaws: > > 1. BlockBackend falls back to the QEMU main loop AioContext when there >is no root

[Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend

2016-09-26 Thread Fam Zheng
From: Stefan Hajnoczi blk_get/set_aio_context() delegate to BlockDriverState without storing the AioContext pointer in BlockBackend. There are two flaws: 1. BlockBackend falls back to the QEMU main loop AioContext when there is no root BlockDriverState. This means the drive loses its Aio