Re: [Qemu-devel] [PATCH v2 5/5] blockdev: use error_set_file_open_failed

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 11:56:29AM -0300, Luiz Capitulino wrote: > On Thu, 15 Mar 2012 00:55:14 +0200 > Alon Levy wrote: > > > This is a little trickier, since those calls chain in many fun ways and > > produce sometimes their own return values reusing existing errno values > > for similar meanin

Re: [Qemu-devel] [PATCH v2 5/5] blockdev: use error_set_file_open_failed

2012-03-15 Thread Luiz Capitulino
On Thu, 15 Mar 2012 00:55:14 +0200 Alon Levy wrote: > This is a little trickier, since those calls chain in many fun ways and > produce sometimes their own return values reusing existing errno values > for similar meanings. In that respect error_set_file_open_failed > specifically ignores EINVAL,

[Qemu-devel] [PATCH v2 5/5] blockdev: use error_set_file_open_failed

2012-03-14 Thread Alon Levy
This is a little trickier, since those calls chain in many fun ways and produce sometimes their own return values reusing existing errno values for similar meanings. In that respect error_set_file_open_failed specifically ignores EINVAL, ENOTSUP and ENOENT. The first two simply are not returned by