Re: [Qemu-devel] [PATCH v2 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-31 Thread Aurelien Jarno
On Mon, May 31, 2010 at 10:35:03PM +0800, chen huacai wrote: > On Sat, May 29, 2010 at 4:56 AM, Aurelien Jarno wrote: > > Please find my comments below. > > > > On Wed, May 19, 2010 at 10:28:36PM +0800, Huacai Chen wrote: > >> Signed-off-by: Huacai Chen > >> --- > >>  Makefile.target            

Re: [Qemu-devel] [PATCH v2 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-31 Thread chen huacai
On Sat, May 29, 2010 at 4:56 AM, Aurelien Jarno wrote: > Please find my comments below. > > On Wed, May 19, 2010 at 10:28:36PM +0800, Huacai Chen wrote: >> Signed-off-by: Huacai Chen >> --- >>  Makefile.target              |    2 +- >>  hw/mips_fulong2e.c           |  421 >>

Re: [Qemu-devel] [PATCH v2 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-28 Thread Aurelien Jarno
Please find my comments below. On Wed, May 19, 2010 at 10:28:36PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |2 +- > hw/mips_fulong2e.c | 421 > ++ > target-mips/translate_init.c | 35

[Qemu-devel] [PATCH v2 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-19 Thread Huacai Chen
Signed-off-by: Huacai Chen --- Makefile.target |2 +- hw/mips_fulong2e.c | 421 ++ target-mips/translate_init.c | 35 3 files changed, 457 insertions(+), 1 deletions(-) create mode 100644 hw/mips_fulong2e.c diff --git a/