Re: [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup

2018-12-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > On Mon, Dec 3, 2018 at 12:59 PM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Add a monitor_destroyed global to check if monitor_cleanup() has been >> > already called. In this case, don't insert the new monitor in the >> > list, but free it i

Re: [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup

2018-12-03 Thread Marc-André Lureau
Hi On Mon, Dec 3, 2018 at 12:59 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Add a monitor_destroyed global to check if monitor_cleanup() has been > > already called. In this case, don't insert the new monitor in the > > list, but free it instead. > > > > Signed-off-by: Marc-An

Re: [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup

2018-12-03 Thread Markus Armbruster
Marc-André Lureau writes: > Add a monitor_destroyed global to check if monitor_cleanup() has been > already called. In this case, don't insert the new monitor in the > list, but free it instead. > > Signed-off-by: Marc-André Lureau The commit message explains what the patch does, but not why we

Re: [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup

2018-10-29 Thread Peter Xu
On Mon, Oct 29, 2018 at 04:57:32PM +0400, Marc-André Lureau wrote: > Add a monitor_destroyed global to check if monitor_cleanup() has been > already called. In this case, don't insert the new monitor in the > list, but free it instead. Pure question: how to trigger the condition when doing monitor

[Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup

2018-10-29 Thread Marc-André Lureau
Add a monitor_destroyed global to check if monitor_cleanup() has been already called. In this case, don't insert the new monitor in the list, but free it instead. Signed-off-by: Marc-André Lureau --- monitor.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/mo