Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-19 Thread Avi Kivity
On 08/18/2011 03:26 PM, Jan Kiszka wrote: On 2011-08-17 16:48, Avi Kivity wrote: On 08/17/2011 04:38 PM, Avi Kivity wrote: The mmio code has s-plane_updated |= mask; /* only used to detect font change */ aren't we losing it? we could easily recover it via dirty logging.

Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-19 Thread Jan Kiszka
On 2011-08-19 08:19, Avi Kivity wrote: On 08/18/2011 03:26 PM, Jan Kiszka wrote: On 2011-08-17 16:48, Avi Kivity wrote: On 08/17/2011 04:38 PM, Avi Kivity wrote: The mmio code has s-plane_updated |= mask; /* only used to detect font change */ aren't we losing it?

Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-18 Thread Jan Kiszka
On 2011-08-17 16:48, Avi Kivity wrote: On 08/17/2011 04:38 PM, Avi Kivity wrote: The mmio code has s-plane_updated |= mask; /* only used to detect font change */ aren't we losing it? we could easily recover it via dirty logging. Yes, I forgot to forward-port plane_updated =

[Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-17 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping,

Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-17 Thread Avi Kivity
On 08/17/2011 03:41 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This

Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-17 Thread Avi Kivity
On 08/17/2011 04:38 PM, Avi Kivity wrote: The mmio code has s-plane_updated |= mask; /* only used to detect font change */ aren't we losing it? we could easily recover it via dirty logging. We can't really recover it. So I think we need to restrict the optimization to