Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 4 March 2015 at 23:35, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Doesn't seem worth changing

[Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Alex Bennée
I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 11845a6..d7fd13f 100644 ---

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Peter Maydell
On 4 March 2015 at 23:35, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Doesn't seem worth changing the current working code to something else that's