Re: [Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

2014-05-30 Thread Stefan Hajnoczi
On Thu, May 29, 2014 at 07:11:27PM +1000, Peter Crosthwaite wrote: On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi stefa...@redhat.com wrote: object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the

Re: [Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

2014-05-29 Thread Peter Crosthwaite
On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi stefa...@redhat.com wrote: object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount

Re: [Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

2014-05-29 Thread Paolo Bonzini
Il 29/05/2014 11:11, Peter Crosthwaite ha scritto: object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug

[Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

2014-05-22 Thread Stefan Hajnoczi
object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-blk child is not finalized! Drop our reference