Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-06-18 Thread John Snow
On 6/3/19 6:14 AM, Vladimir Sementsov-Ogievskiy wrote: > 01.06.2019 3:06, John Snow wrote: >> >> >> On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: >>> qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all >>> readonly. But the latter don't work, as >>> qcow2_store_persi

Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
18.06.2019 17:30, John Snow wrote: > > > On 6/3/19 6:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> 01.06.2019 3:06, John Snow wrote: >>> >>> >>> On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all readonly. But t

Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-06-03 Thread Vladimir Sementsov-Ogievskiy
01.06.2019 3:06, John Snow wrote: > > > On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: >> qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all >> readonly. But the latter don't work, as >> qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. >> It's OK fo

Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-05-31 Thread John Snow
On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: > qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all > readonly. But the latter don't work, as > qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. > It's OK for inactivation but bad idea for reopen-ro.

[Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-05-31 Thread Vladimir Sementsov-Ogievskiy
qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all readonly. But the latter don't work, as qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. It's OK for inactivation but bad idea for reopen-ro. And this leads to the following bug: Assume we have persistent bitm