Re: [Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing

2014-11-13 Thread Stefan Hajnoczi
On Mon, Nov 10, 2014 at 03:48:52PM +0100, Max Reitz wrote: > On 2014-11-07 at 20:39, Kevin Wolf wrote: > >The only image format driver that even potentially accesses anything > >after 512 bytes in its bdrv_probe() implementation is VMDK, which reads > >a plain-text descriptor file. In practice, the

Re: [Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing

2014-11-10 Thread Max Reitz
On 2014-11-07 at 20:39, Kevin Wolf wrote: The only image format driver that even potentially accesses anything after 512 bytes in its bdrv_probe() implementation is VMDK, which reads a plain-text descriptor file. In practice, the field it's looking for seems to come first and will be well within

[Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing

2014-11-07 Thread Kevin Wolf
The only image format driver that even potentially accesses anything after 512 bytes in its bdrv_probe() implementation is VMDK, which reads a plain-text descriptor file. In practice, the field it's looking for seems to come first and will be well within the first 512 bytes, too. Signed-off-by: Ke