Re: [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

2015-10-20 Thread Paolo Bonzini
On 19/10/2015 19:57, Eduardo Habkost wrote: > On Mon, Oct 19, 2015 at 07:46:51AM -1000, Richard Henderson wrote: >> On 10/19/2015 07:30 AM, Eduardo Habkost wrote: > +/* Notice when we should enable calls to bpt_io. */ > +return (hw_breakpoint_enabled(env->dr[7], index)

Re: [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

2015-10-19 Thread Eduardo Habkost
On Fri, Oct 16, 2015 at 01:23:36PM -0300, Eduardo Habkost wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Rebase on top of new version of "Re-introduce

Re: [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

2015-10-19 Thread Eduardo Habkost
On Mon, Oct 19, 2015 at 07:46:51AM -1000, Richard Henderson wrote: > On 10/19/2015 07:30 AM, Eduardo Habkost wrote: > >>>+/* Notice when we should enable calls to bpt_io. */ > >>>+return (hw_breakpoint_enabled(env->dr[7], index) > >>>+? HF_IOBPT_MASK : 0); >

Re: [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

2015-10-19 Thread Richard Henderson
On 10/19/2015 07:30 AM, Eduardo Habkost wrote: >+/* Notice when we should enable calls to bpt_io. */ >+return (hw_breakpoint_enabled(env->dr[7], index) >+? HF_IOBPT_MASK : 0); checkpatch.pl error: ERROR: return is not a function, parentheses are not required

[Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

2015-10-16 Thread Eduardo Habkost
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase on top of new version of "Re-introduce optimal breakpoint removal" --- target-i386/bpt_helper.c | 98