Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-24 Thread Xiao Guangrong
On 07/23/2018 05:01 PM, Peter Xu wrote: Yes, it's sufficient for current thread model, will drop it for now and add it at the time when the lockless mutilthread model is applied. :) Ah I think I see your point. Even if so I would think it better to do any extra cleanup directly in compress

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:53:11PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 04:35 PM, Peter Xu wrote: > > On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 07/23/2018 01:49 PM, Peter Xu wrote: > > > > On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 04:35 PM, Peter Xu wrote: On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: On 07/23/2018 01:49 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong flush_compressed_data() needs to wait all compre

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 01:49 PM, Peter Xu wrote: > > On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > flush_compressed_data() needs to wait all compression threads to > >

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 01:49 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong flush_compressed_data() needs to wait all compression threads to finish their work, after that all threads are free until the migration feeds new request to

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-22 Thread Peter Xu
On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > flush_compressed_data() needs to wait all compression threads to > finish their work, after that all threads are free until the > migration feeds new request to them, reducing its call can improve

[Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-19 Thread guangrong . xiao
From: Xiao Guangrong flush_compressed_data() needs to wait all compression threads to finish their work, after that all threads are free until the migration feeds new request to them, reducing its call can improve the throughput and use CPU resource more effectively We do not need to flush all t