Re: [Qemu-devel] [PATCH v2 8/8] target/s390x: Fix risbg handling

2017-07-02 Thread Aurelien Jarno
On 2017-07-01 13:26, Richard Henderson wrote: > The rotation is to the left, but extract shifts to the right. > The computation of the extract parameters needs adjusting. > > For the entry condition, simplify > > 64 - rot + len <= 64 > -rot + len <= 0 > len <= rot > > Reported-

[Qemu-devel] [PATCH v2 8/8] target/s390x: Fix risbg handling

2017-07-01 Thread Richard Henderson
The rotation is to the left, but extract shifts to the right. The computation of the extract parameters needs adjusting. For the entry condition, simplify 64 - rot + len <= 64 -rot + len <= 0 len <= rot Reported-by: David Hildenbrand Suggested-by: Aurelien Jarno Signed-