Re: [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread Peter Maydell
On 23 January 2014 20:08, C Fontana wrote: >> +if (extended_result) { >> +tcg_temp_free(tcg_src_hi); > > > > should this be tcg_temp_free_i64 ? Yes, though it doesn't actually make a difference here since we know we're building a 64 bit target QEMU. >> +return; > > > no harm but

[Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread C Fontana
Hi Peter, just two nits, answering from the tablet so sorry if arrives with strange formatting, hope not.. On Thursday, January 23, 2014, Peter Maydell > wrote: > From: Alex Bennée > > This implements a subset of the AdvSIMD shift operations (namely all the > none saturating or narrowing ones).

[Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread Peter Maydell
From: Alex Bennée This implements a subset of the AdvSIMD shift operations (namely all the none saturating or narrowing ones). The actual shift generation code itself is common for both the scalar and vector cases but wrapped with either vector element iteration or the fp reg access. The roundin