Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-05 Thread Fam Zheng
On Thu, 06/05 06:09, Paolo Bonzini wrote: Il 05/06/2014 05:50, Fam Zheng ha scritto: Can you try moving the req allocation and assignments inside process_request instead? Then you can fill in req-out directly without the struct assignment. The owners of req are do_rdwr_cmd and

[Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-04 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 96068cd..323793a 100644 --- a/hw/block/dataplane/virtio-blk.c +++

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-04 Thread Paolo Bonzini
Il 05/06/2014 03:58, Fam Zheng ha scritto: Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 96068cd..323793a

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-04 Thread Fam Zheng
On Thu, 06/05 04:55, Paolo Bonzini wrote: Il 05/06/2014 03:58, Fam Zheng ha scritto: Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-04 Thread Paolo Bonzini
Il 05/06/2014 05:50, Fam Zheng ha scritto: Can you try moving the req allocation and assignments inside process_request instead? Then you can fill in req-out directly without the struct assignment. The owners of req are do_rdwr_cmd and do_flush_cmd, but do_scsi_cmd and do_get_id_cmd don't