Re: [Qemu-devel] [PATCH v2 for-2.4 12/12] axienet: Flush queued packets when rx is done

2015-07-15 Thread Jason Wang
On 07/16/2015 11:32 AM, Fam Zheng wrote: > On Thu, 07/16 10:58, Jason Wang wrote: >> >> On 07/15/2015 06:19 PM, Fam Zheng wrote: >>> eth_can_rx checks s->rxsize and returns false if it is non-zero. Because >>> of the .can_receive semantics change, this will make the incoming queue >>> disabled by

Re: [Qemu-devel] [PATCH v2 for-2.4 12/12] axienet: Flush queued packets when rx is done

2015-07-15 Thread Fam Zheng
On Thu, 07/16 10:58, Jason Wang wrote: > > > On 07/15/2015 06:19 PM, Fam Zheng wrote: > > eth_can_rx checks s->rxsize and returns false if it is non-zero. Because > > of the .can_receive semantics change, this will make the incoming queue > > disabled by peer, until it is explicitly flushed. So w

Re: [Qemu-devel] [PATCH v2 for-2.4 12/12] axienet: Flush queued packets when rx is done

2015-07-15 Thread Jason Wang
On 07/15/2015 06:19 PM, Fam Zheng wrote: > eth_can_rx checks s->rxsize and returns false if it is non-zero. Because > of the .can_receive semantics change, this will make the incoming queue > disabled by peer, until it is explicitly flushed. So we should flush it > when s->rxsize is becoming zero

[Qemu-devel] [PATCH v2 for-2.4 12/12] axienet: Flush queued packets when rx is done

2015-07-15 Thread Fam Zheng
eth_can_rx checks s->rxsize and returns false if it is non-zero. Because of the .can_receive semantics change, this will make the incoming queue disabled by peer, until it is explicitly flushed. So we should flush it when s->rxsize is becoming zero. Squash eth_can_rx semantics into etx_rx and drop